Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

!include doesn't work with files encoded as UTF-8 BOM #312

Closed
kev-andrews opened this issue Jul 18, 2024 · 2 comments
Closed

!include doesn't work with files encoded as UTF-8 BOM #312

kev-andrews opened this issue Jul 18, 2024 · 2 comments
Labels

Comments

@kev-andrews
Copy link

Description

Currently, structurizr lite does not handle .dsl files with a UTF-8 BOM very well. It throws hard-to-debug errors, such as
Identifiers can only contain the following characters
It would be great if you could add support for UTF-8 BOM. This seems to have been an issue in the Java version at some point as well structurizr/dsl@00faec0

Priority

I have no budget and there's no rush, please add this feature for free

More information

No response

@simonbrowndotje
Copy link
Contributor

I've started Lite against this file (the example you pointed to) and it works for me. Do you have any information on how to reproduce what you're seeing?

@simonbrowndotje simonbrowndotje changed the title Add support for parsing DSL Files with UTF-8 BOM Lite doesn't parse DSL Files with UTF-8 BOM Jul 18, 2024
@kev-andrews
Copy link
Author

Maybe it has to do with !include... I noticed the error when using !include and including a .dsl file with UTF8 BOM from a file without a BOM. Removing the BOM in the included file fixes the issue immediately.

@simonbrowndotje simonbrowndotje changed the title Lite doesn't parse DSL Files with UTF-8 BOM !include doesn't work with files encoded as UTF-8 BOM Jul 19, 2024
@simonbrowndotje simonbrowndotje transferred this issue from structurizr/lite Jul 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants