-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Minify crosslinks JSON #9
Comments
Just using |
Then again, minifiying it in Go / Crosslinker step might make diffs harder when adding new entries. Maybe consider minify being either a step of its own or something done in NPM module before release. Edit: and should we opt for minifying keys, this should be automated by this build step. Maybe just a script that parses humanreadable keys to minified ones & then minifies the whole thing for the NPM module. Would still keep readability & debuggability of the crosslinker produced json output. |
Preliminary test would point to simple line based minify only shaving couple of MB off from the 9 MB sourceset. So:
|
The script produces more crosslinks than expected, which is a positive issue to have. However, the produced json file is large, so it would do the planet some good to make it smaller. Currently around 7 MB (EDIT: now almost 9 MB with added content), which is a lot for additional meta info.
Possible avenues:
Minifying keys does produce overhead to Node.js side, so do consider if it gives as much benefits here as it did in Old Swedish dictionary. There we had many more keys and almost all of them were longer than the ones we have here. First and last avenues may be the most beneficial ones without adding too much burden to processing time.
The text was updated successfully, but these errors were encountered: