Add /* AGENT_SHEET */ to existing styles that need it

[JasonBarnabe]

stylish-userstyles/stylish#78

Add /* AGENT_SHEET */ to styles that require it to work. I know at least scrollbar styles will need it...

[JasonBarnabe]

Current styles with AGENT_SHEET: 85684, 88199.

[JasonBarnabe]

714a862 is a script to add AGENT_SHEET to styles that use scrollbar as a type selector.

[JasonBarnabe]

Added to:

49, 1038, 1185, 2165, 3338, 3577, 4036, 5449, 5630, 6023, 8908, 9290, 9533, 9862, 11624, 12340, 12903, 13601, 14392, 14405, 16377, 16957, 18356, 18874, 19104, 19359, 19401, 19561, 20061, 20277, 20412, 20828, 21308, 21763, 24068, 24273, 24425, 24724, 25395, 25430, 25720, 25865, 27186, 27352, 30274, 31267, 31614, 31650, 31923, 32717, 33303, 33524, 33606, 33982, 35058, 35272, 37962, 38440, 38725, 38954, 38983, 39033, 39153, 39217, 39445, 39460, 39704, 39926, 39981, 40330, 40339, 40453, 42134, 42258, 43655, 44217, 44539, 45575, 45632, 45641, 45720, 45732, 46044, 46329, 46403, 46617, 46656, 46905, 47355, 47362, 47391, 47951, 49241, 49632, 50046, 50113, 50550, 50592, 51382, 51401, 51701, 52223, 53582, 53668, 53683, 53959, 54298, 55006, 55983, 57731, 58089, 58318, 58692, 59245, 60328, 60519, 60979, 61019, 62204, 62205, 62433, 62434, 62727, 63354, 63607, 63796, 63797, 64593, 65013, 65542, 67943, 67944, 67969, 67992, 67997, 68038, 68236, 68266, 68363, 70031, 71073, 71074, 71112, 71113, 71569, 71925, 75009, 76128, 76336, 76999, 77365, 77546, 77611, 78651, 78855, 78937, 78939, 78968, 79097, 79119, 79323, 79762, 80125, 80854, 80900, 81314, 81421, 81503, 81979, 82178, 82419, 82424, 82474, 82493, 82763, 83023, 83295, 83431, 83509, 83902, 83963, 84070, 84337, 84530, 85006, 85476, 85492, 85493, 85851, 86166, 86215, 86514, 87547, 87551, 88202, 88259, 88779, 88848, 88916, 88999, 89295, 89620, 90111, 90146, 90297, 90494, 90511, 90523, 90896, 90972, 91091, 91480, 91948, 92945, 93006, 93163, 93307, 93360, 93680, 93814, 93938, 93942, 93991, 94095, 94233, 94453, 94520, 94689, 94744, 94901, 95006, 95159, 95224, 95315, 95554, 95572, 95594, 95792, 95820, 96045, 96087, 96091, 96118, 96257, 96501, 96557, 96661, 96755

[JasonBarnabe]

Per http://forum.userstyles.org/discussion/39738/stylish-for-firefox-1-4-1b1 this is also needed for things that style the internals of form controls.

ce120d4

Modified:

312, 313, 336, 1195, 1395, 1554, 1581, 1691, 1782, 1854, 2014, 2117, 2439, 2456, 2458, 2513, 2658, 2708, 2760, 2802, 3050, 3149, 3414, 3466, 3505, 3697, 3763, 3927, 3998, 4089, 4207, 4238, 4379, 4382, 4531, 4562, 4792, 4955, 5122, 5130, 5267, 5495, 5594, 6044, 6185, 6204, 6279, 6510, 6524, 6594, 6751, 6899, 6998, 7138, 7219, 7350, 7351, 7357, 7449, 7451, 7455, 7506, 7756, 7832, 7923, 8102, 8613, 9427, 9443, 9444, 10019, 10020, 10116, 10120, 10320, 10322, 10383, 10384, 10431, 10432, 10476, 10507, 10508, 10513, 10926, 10939, 11010, 11245, 11355, 11464, 11483, 11564, 11640, 12376, 12483, 12484, 12661, 12732, 12746, 12836, 12837, 12944, 13023, 13107, 13745, 14158, 14391, 14893, 14895, 15215, 15821, 15825, 15908, 15957, 16531, 17025, 17249, 17256, 17700, 17708, 17719, 17721, 17728, 18192, 18317, 18347, 18355, 18473, 18551, 18599, 18750, 18846, 18876, 18995, 19375, 19468, 19486, 19630, 19631, 19633, 19661, 19662, 19697, 19698, 19728, 19747, 19801, 20108, 20259, 20331, 20352, 20353, 20355, 20359, 20366, 20368, 20397, 20439, 20466, 21009, 21087, 21191, 21314, 21545, 21629, 21639, 21758, 22200, 22308, 22381, 22406, 22463, 22521, 22547, 22553, 22745, 22747, 22749, 22750, 22848, 22861, 22967, 23005, 23046, 23205, 23218, 23285, 23305, 23810, 23827, 23843, 23994, 24028, 24142, 24209, 24230, 24335, 24378, 24574, 24791, 24827, 24840, 24868, 25027, 25043, 25125, 25398, 25431, 25432, 25435, 25436, 25439, 25441, 25442, 25449, 25450, 25452, 25453, 25454, 25455, 25456, 25457, 25458, 25459, 25460, 25461, 25462, 25463, 25465, 25466, 25467, 25468, 25469, 25470, 25471, 25513, 25866, 26007, 26370, 26571, 27031, 27071, 27324, 28530, 28533, 28536, 28563, 28797, 28824, 29065, 29068, 29069, 29441, 29443, 29507, 29585, 29756, 29808, 29916, 30198, 30201, 30256, 31211, 31367, 31496, 31986, 31996, 33918, 34967, 35557, 35770, 35951, 36261, 36614, 36615, 36690, 36783, 37452, 37474, 37545, 37829, 37868, 38070, 38162, 38189, 38595, 38687, 39057, 39223, 39404, 39553, 39632, 40090, 40405, 41802, 42164, 43368, 43463, 44367, 44530, 44650, 44724, 44896, 44906, 45077, 45290, 45729, 45783, 45830, 45888, 45987, 45989, 46002, 46026, 46081, 46321, 46508, 46794, 46812, 47444, 47462, 47531, 47632, 47730, 48278, 48362, 48571, 49162, 49269, 50191, 50269, 50272, 50915, 50983, 51107, 51764, 52178, 52245, 53059, 53152, 53245, 53337, 53361, 53722, 53995, 54699, 54895, 54897, 54900, 54903, 54922, 54932, 54951, 55239, 55525, 56012, 56067, 56104, 56304, 56366, 56580, 57114, 57301, 58410, 58447, 58653, 58668, 59351, 59996, 60028, 60451, 60773, 60930, 60985, 61054, 61289, 61298, 61377, 61647, 62091, 62127, 62226, 62328, 62746, 62954, 63216, 63504, 63608, 63610, 63795, 63960, 64023, 64045, 64085, 64086, 64220, 64512, 64987, 64988, 64997, 65241, 65246, 65252, 65313, 65338, 65352, 65356, 65358, 65379, 65529, 65608, 65821, 65830, 65956, 66161, 66229, 66271, 66289, 66366, 66725, 66807, 67056, 67399, 67708, 67725, 67875, 68198, 68217, 68222, 68513, 68827, 68978, 69015, 69100, 69153, 69289, 69551, 69614, 69824, 69994, 70047, 70076, 70600, 70696, 70789, 71365, 71430, 71589, 71798, 71949, 71958, 72039, 72319, 74455, 74466, 74541, 74691, 74700, 74715, 74722, 74867, 74878, 74897, 74968, 75217, 75379, 75751, 76142, 76149, 76562, 76632, 76845, 77036, 77052, 77090, 77398, 77450, 77648, 77662, 77871, 78040, 78377, 78405, 78676, 78774, 79654, 79662, 79753, 79883, 79899, 79900, 79901, 80064, 80130, 80208, 80275, 80493, 81212, 81480, 81488, 81690, 82067, 82502, 82546, 82569, 82926, 83013, 83097, 83306, 83310, 83311, 83312, 83490, 84004, 84018, 84215, 84811, 85039, 85202, 85391, 85459, 85815, 86011, 86488, 86516, 86635, 86678, 86824, 87066, 87397, 87402, 87420, 87421, 87423, 87532, 87847, 88090, 88093, 88462, 88472, 88550, 88590, 88654, 88864, 88878, 88888, 88894, 88946, 88947, 89115, 89211, 89222, 89558, 89605, 90085, 90215, 90353, 90419, 90432, 90438, 90578, 90880, 90893, 91086, 91101, 91120, 91139, 91182, 91225, 91280, 91411, 91421, 91580, 91635, 91657, 91889, 91962, 92022, 92341, 92729, 92897, 92902, 92940, 93101, 93277, 93350, 93352, 93353, 93373, 93382, 93384, 93445, 93478, 93534, 93568, 93569, 93803, 93907, 93993, 94209, 94218, 94368, 94534, 94669, 94694, 94763, 94911, 95072, 95077, 95161, 95168, 95395, 95425, 95512, 95793, 95809, 95865, 95920, 96016, 96026, 96033, 96063, 96262, 96423, 96459, 96471, 96500, 96585, 96620, 96703, 96864

[JasonBarnabe]

Tweaked the script to include some more elements e38f981 and reran:

17728, 25537, 25538, 25539, 25540, 43463, 45830, 46129, 49241, 64045, 64512, 65379, 80275, 81480, 83509, 84215, 87066, 88093, 92897, 95168, 95506, 95512, 95820, 96498, 96703, 97000, 97012, 97084, 97116, 97159, 97180, 97204, 97264, 97411, 97456, 97475, 97510, 97538, 97541

[silverwind]

Hey, style 37035 here. AGENT_SHEET is needed for form elements with -moz-appearance:

  select, input, textarea {
    -moz-appearance: none !important;
    background: #181818 !important;
    border-color: #666 !important;
    border-style: solid !important;
    color: #ddd !important;
  }

[JasonBarnabe]

It doesn't seem to be needed for -moz-appearance per se. DOM Inspector reports that the computed -moz-apperance is "none" without AGENT_SHEET. The other properties, on the other hand, don't seem to get applied regardless of specificity without the use of AGENT_SHEET. This is probably because Firefox is dumb about styling checkboxes.

I'm not sure I can reliably find these cases, because in the example you post, it's not clear whether the intention is to style checkboxes or not. It's definitely something to be added to the documentation, though.

[silverwind]

You're right, it actually isn't necessary to provide -moz-appearance for it to work. What about detecting background/border/color styles on input and other related HTML4 form elements? I think these three properties are the only ones that work on them.

I just tested and a style like

input {
  background: #181818 !important;
  border-color: #666 !important;
  border-style: solid !important;
  color: #ddd !important;
}

wasn't applied on checkboxes until I had set AGENT_SHEET.

[JasonBarnabe]

It works fine without AGENT_SHEET with regular text inputs, and I don't want to add AGENT_SHEET where not needed. This may just be a manual fix for any style that does it.

[silverwind]

You're right, the intend isn't obious. In the end it's Mozilla's quirky form styling code which is at fault here. That code must date back to Netscape times.