Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Faker::Coffee.intensifier #1141

Merged
merged 4 commits into from
Jun 2, 2018
Merged

Conversation

oyeanuj
Copy link
Contributor

@oyeanuj oyeanuj commented Feb 5, 2018

There was a method missing for coffee intensifier, just added that.

@vbrazo
Copy link
Member

vbrazo commented May 14, 2018

@oyeanuj Thanks for contributing 🥇

You should rebase with master and fix the rubocop violations.

You should also update the doc/coffee.md.

@vbrazo vbrazo force-pushed the oyeanuj-patch-1 branch from f6d9bbc to e4605b5 Compare June 2, 2018 02:37
@vbrazo vbrazo force-pushed the oyeanuj-patch-1 branch from e4605b5 to bf79cf1 Compare June 2, 2018 02:37
@vbrazo vbrazo changed the title Add method for coffee intensifier Add Faker::Coffee.intensifier Jun 2, 2018
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had free time today and rebase your branch with master. I also updated the doc/coffee.md and our changelog 👍

Since you're a first time contributor, I'd like to say welcome :)

@vbrazo vbrazo merged commit 14ae717 into faker-ruby:master Jun 2, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:23
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add method for coffee intensifier

* Fix rubocop violations and update changelog

* Update Faker::Coffee docs
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants