Dota API: Str Heroes, heroes quotes, Items, Teams, Players

[felipesousafs]

As described in the commit message, added some heroes (and hero quotes), items, teams and players.

[shannonwells]

Just need to restore the rake task, otherwise 👍

[shannonwells]

This eliminates all the rest of the tests and should be put back to what's on master.

[vbrazo]

Please remove the instance method puts to keep the tests clean

[vbrazo]

Same here. Please do not forget to remove the other puts below.

[vbrazo]

Travis is red because of this:

Error: test_determinism(TestDeterminism): RuntimeError: Faker::Dota.quote raised "wrong number of arguments (given 0, expected 1)"
/faker/test/test_determinism.rb:36:in `rescue in store_result'
/faker/test/test_determinism.rb:33:in `store_result'
/faker/test/test_determinism.rb:14:in `block in test_determinism'
     11:   def test_determinism
     12:     Faker::Config.random = Random.new(42)
     13:     @all_methods.each_index do |index|
  => 14:       store_result @all_methods[index]
     15:     end
     16:     @first_run.freeze
     17:     Faker::Config.random = Random.new(42)
/faker/test/test_determinism.rb:13:in `each_index'
/faker/test/test_determinism.rb:13:in `test_determinism'

@felipesousafs please fix it and let us know when it's ready for review again. Thanks!

[vbrazo]

After making the changes, could you also update the CHANGELOG.md and add the title of this PR + your GitHub ID?

[coveralls]

Pull Request Test Coverage Report for Build 2171

• 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
• 7 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.02%) to 99.65%

---

Files with Coverage Reduction	New Missed Lines	%
lib/faker/time.rb	7	100.0%

Totals
Change from base Build 2135:	0.02%
Covered Lines:	2278
Relevant Lines:	2286

---

💛 - Coveralls

[vbrazo]

You still need to fix the rubocop violations. Please just run bundle exec rubocop -a and then we should be fine. @felipesousafs

[vbrazo]

Let's get this PR merged today. Lemme know when you fix the violations.

[vbrazo]

Travis is still red because of Rubocop 😢

[felipesousafs]

test/test_faker_dota.rb:6:15: C: Style/PercentLiteralDelimiters: %w-literals should be delimited by [ and ]. @heroes = %w(abaddon alchemist axe beastmaster brewmaster bristleback centaur ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ test/test_faker_dota.rb:7:16: C: Layout/AlignArray: Align the elements of an array literal if they span more than one line. chaos_knight clockwerk doom dragon_knight earth_spirit earthshaker ^^^^^^^^^^^^

What does this means and how can I fix this?
(I'm new with this 😄 )

[vbrazo]

No worries. You should use Rubocop in your project because it'll force you to follow a few great Ruby practices. Lemme take a look at your question.

[vbrazo]

I basically pulled your branch and ran bundle exec rubocop -a and fixed them. Take a look at the Rubocop repository to understand more about this gem 👍

[felipesousafs]

Nice!
Thanks for the tips, man.