Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Space: Added space launch vehicule #1192

Merged
merged 5 commits into from
May 17, 2018
Merged

Space: Added space launch vehicule #1192

merged 5 commits into from
May 17, 2018

Conversation

Gauth-ier
Copy link
Contributor

  • Adding recent space company
  • Adding launch vehicule name

@Gauth-ier Gauth-ier changed the title Added space launch vehicule Added space launch vehicule in space section Apr 25, 2018
@Gauth-ier Gauth-ier changed the title Added space launch vehicule in space section Space: Added space launch vehicule Apr 25, 2018
@vbrazo vbrazo self-requested a review May 16, 2018 06:12
vbrazo
vbrazo approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 🥇

Could you please rebase, install the new gems and run bundle exec rubocop -a?

@vbrazo
Copy link
Member

vbrazo commented May 16, 2018

Could you please update the CHANGELOG.md and add the title of this PR + your GitHub ID?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2139

  • 13 of 15 (86.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 99.64%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/faker/types.rb 11 13 84.62%
Totals Coverage Status
Change from base Build 2135: 0.006%
Covered Lines: 2216
Relevant Lines: 2224
💛 - Coveralls

@Gauth-ier
Copy link
Contributor Author

Hi @vbrazo I think I did something the wrong way isn't it ? This is my first ever contribution to an open source project.

@faker-ruby faker-ruby deleted a comment from coveralls May 17, 2018
@vbrazo vbrazo merged commit 799fd6e into faker-ruby:master May 17, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:28
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@Gauth-ier @vbrazo
Space: Added space launch vehicule (faker-ruby#1192)
2470d6a 
* - Adding more space company and space launch vehicule

* - Adding more space company and space launch vehicule

* - add info in the changelog.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@Gauth-ier Gauth-ier

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauth-ier @vbrazo @coveralls