Add Faker::StrangerThings #1199
Conversation
Added Stranger Things character and quotes with passing tests and docs.
test/test_stranger_thing.rb
Outdated
| class TestStrangerThings < Test::Unit::TestCase | ||
| def setup | ||
| @tester = Faker::StrangerThings | ||
| end |
There was a problem hiding this comment.
It seems to me that this identation is wrong.
|
@Connerh92 could you please rebase, install the new gems and run |
|
Could you please update the CHANGELOG.md and add the title of this PR + your github id? |
Added Stranger Things character and quotes with passing tests and docs.
Gemfile
Outdated
| gem "rake" | ||
| gem "minitest" | ||
| gem "timecop" | ||
| end |
There was a problem hiding this comment.
Why are you adding these gems in this file?
We are no longer declaring gems in this file. Rubocop has removed the gems and added to another file. If you want to declare new gems, check faker.gemspec out please.
Please make sure to run bundle install && bundle exec rubocop -a && rake and get no failures.
There was a problem hiding this comment.
I understand that you want to use pry and I personally believe it's a great gem and we should add it to the project.
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
6394a28 to
d11bd7e
Compare
|
Thanks for helping out. |
* Add Faker::StrangerThings Added Stranger Things character and quotes with passing tests and docs. * Add Faker::StrangerThings Added Stranger Things character and quotes with passing tests and docs. * merge master, and conflicts * added changelog addition * Merge remote-tracking branch 'upstream/master'
Added Stranger Things character and quotes with passing tests and docs.