Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix minitest warnings #1223

Merged
merged 2 commits into from
May 19, 2018
Merged

Fix minitest warnings #1223

merged 2 commits into from
May 19, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented May 19, 2018

Fix minitest warnings:

/root/faker-ruby/faker/test/test_faker_music.rb:37: warning: nested repeat operator '?' and '*' was replaced with '*' in regular expression: /([A-Z])*(b|#){0,1}*(m){0,1}/

/root/faker-ruby/faker/test/test_faker_music.rb:45: warning: nested repeat operator '?' and '*' was replaced with '*' in regular expression: /([A-Z])*(b|#){0,1}*([a-zA-Z0-9]{0,4})/

/root/faker-ruby/faker/test/test_helper.rb:6:in `<top (required)>': [DEPRECATION] ::[] is deprecated. Use ::new instead.

This PR is related to this issue #1206.

@vbrazo vbrazo self-assigned this May 19, 2018
@vbrazo vbrazo changed the title Fix mini test warnings Fix minitest warnings May 19, 2018
@coveralls
Copy link

coveralls commented May 19, 2018

Pull Request Test Coverage Report for Build 2182

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 99.65%

Files with Coverage Reduction New Missed Lines %
lib/faker/time.rb 7 100.0%
Totals Coverage Status
Change from base Build 2173: 0.0%
Covered Lines: 2278
Relevant Lines: 2286

💛 - Coveralls

@faker-ruby faker-ruby deleted a comment from coveralls May 19, 2018
@vbrazo vbrazo force-pushed the fixes/fix-warnings branch from 5ca1777 to 7fb87e0 Compare May 19, 2018 21:10
@vbrazo vbrazo merged commit 2aa47dc into master May 19, 2018
@vbrazo vbrazo deleted the fixes/fix-warnings branch May 19, 2018 21:17
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants