Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Faker::Science.element_symbol #1266

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Add Faker::Science.element_symbol #1266

merged 2 commits into from
Jun 2, 2018

Conversation

timcustard
Copy link
Contributor

@timcustard timcustard commented Jun 2, 2018 •
edited by vbrazo
Loading

  • Add Faker::Science.element_symbol
  • Add docs
  • Add tests

@vbrazo vbrazo changed the title Added Symbols for Elements to Science Add Faker::Science.element_symbol Jun 2, 2018
vbrazo
vbrazo approved these changes Jun 2, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. I saw that you're a first time contributor, welcome 🥇

Overall looks good. You did pretty much what we expect:

  • added docs
  • new feature
  • tests
  • locales

Congrats 💯

@vbrazo
Copy link
Member

vbrazo commented Jun 2, 2018

You worked on your master branch. Please create a new branch next time.

@vbrazo vbrazo merged commit 8848982 into faker-ruby:master Jun 2, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:22
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@timcustard @vbrazo
Add Faker::Science.element_symbol (faker-ruby#1266)
8df0aea 
* Added Symbols for Elements to Science

* Update CHANGELOG.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vbrazo vbrazo Awaiting requested review from vbrazo

Assignees

@timcustard timcustard

Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timcustard @vbrazo