Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Faker::Relationship #1346

Merged
merged 4 commits into from
Sep 2, 2018
Merged

Add Faker::Relationship #1346

merged 4 commits into from
Sep 2, 2018

Conversation

QuantumWaver
Copy link
Contributor

Here is my faker module for handling familial relationships, such as 'Mother', 'Father', 'Sister', 'Grandmother', etc. I believe I followed all your contributing guidelines to the letter. Thanks for allowing me to contribute! This is a great gem!

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo
Copy link
Member

vbrazo commented Sep 2, 2018

and welcome!

@vbrazo vbrazo merged commit 53600c9 into faker-ruby:master Sep 2, 2018
@QuantumWaver
Copy link
Contributor Author

Awesome! Thank you!!!

davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Add Faker::Relationship

* Update relationship.md

* Update CHANGELOG.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants