Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Quick number method bugfix #1384

Merged
merged 4 commits into from
Oct 6, 2018
Merged

Quick number method bugfix #1384

merged 4 commits into from
Oct 6, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Oct 4, 2018

Fixes #1378

@vbrazo vbrazo self-assigned this Oct 4, 2018
@vbrazo
Copy link
Member Author

vbrazo commented Oct 4, 2018

@dennym @oleksii-ti please take a look and lemme know what you think.

@dennym
Copy link

dennym commented Oct 5, 2018

Doesn't this remove the leading zero functionality? Although the leading zero thingy killed the random decimal generation.

@vbrazo
Copy link
Member Author

vbrazo commented Oct 5, 2018 •
edited
Loading

@dennym no, it doesn't because we have Faker::Number.leading_zero_number. Take a look at the docs.

Besides that, the documentation specifies clearly that Faker::Number.number produces a number of the specified digits where the leading digit is never 0.

@vbrazo vbrazo merged commit d21ca37 into faker-ruby:master Oct 6, 2018
@vbrazo vbrazo deleted the fixes/fix-number-method branch October 6, 2018 15:02
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Quick number method bugfix (faker-ruby#1384)
c6b9474 
* Quick number method bugfix

* Update CHANGELOG.md

* Update README.md

* Update CHANGELOG.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@vbrazo vbrazo

Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbrazo @dennym