Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Distinguish between 'brand' and 'name' #1514

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Distinguish between 'brand' and 'name' #1514

merged 2 commits into from
Jan 23, 2019

Conversation

iwaim
Copy link
Contributor

@iwaim iwaim commented Jan 23, 2019

These are name of beer.

  • Kirin Inchiban
  • Delirium Tremens
  • Delirium Noctorum
  • Sapporo Premium

@iwaim
Distinguish between 'brand' and 'name'
f8a7163 
These are name of beer.
- Kirin Inchiban
- Delirium Tremens
- Delirium Noctorum
- Sapporo Premium
@vbrazo vbrazo assigned vbrazo and iwaim and unassigned vbrazo Jan 23, 2019
@vbrazo vbrazo self-requested a review January 23, 2019 15:54
vbrazo
vbrazo approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch 👍

@vbrazo vbrazo merged commit f496864 into faker-ruby:master Jan 23, 2019
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@iwaim @vbrazo
Distinguish between 'brand' and 'name' (faker-ruby#1514)
ae47f72 
* Distinguish between 'brand' and 'name'

These are name of beer.
- Kirin Inchiban
- Delirium Tremens
- Delirium Noctorum
- Sapporo Premium

* Update CHANGELOG.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@iwaim iwaim

Labels
🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwaim @vbrazo