Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Eichmann surname #439

Merged
merged 2 commits into from
May 18, 2018
Merged

Remove Eichmann surname #439

merged 2 commits into from
May 18, 2018

Conversation

jonahwh
Copy link
Contributor

@jonahwh jonahwh commented Oct 26, 2015

Remove Eichmann surname as it does not have a good connotation.

@vbrazo
Copy link
Member

vbrazo commented May 14, 2018

@jonahwh could you fix the conflicts and let me know when it's ready for review?

@jonahwh
Copy link
Contributor Author

jonahwh commented May 14, 2018

@vbrazo done

@vbrazo vbrazo self-requested a review May 14, 2018 16:51
@vbrazo vbrazo merged commit b8565c3 into faker-ruby:master May 18, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:32
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants