Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Display error if room creation fails #14

Closed
sunjam opened this issue Apr 27, 2020 · 5 comments
Closed

Display error if room creation fails #14

sunjam opened this issue Apr 27, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sunjam
Copy link

sunjam commented Apr 27, 2020

I'd like to kindly request an error of some sort be displayed if room creation fails.

Thanks!

@sualko
Copy link
Member

sualko commented Apr 27, 2020

Please specify what you mean by "room creation".

@sunjam
Copy link
Author

sunjam commented Apr 27, 2020

I attempted to create a room and as far as I can tell it did not work, but I did not receive any sort of confirmation or error stating what happened. Nothing happened.
Screenshot_20200427_134944

@FlavioBill
Copy link

FlavioBill commented Apr 27, 2020

Hi... try to help... during inset in oc_bbb_room there is an error:
Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'INSERT INTO oc_bbb_rooms (uid, name, welcome, max_participants, attendee_password, moderator_password, record, user_id) VALUES(?, ?, ?, ?, ?, ?, ?, ?)' with params ["XXXXXXXXXXX", "MyRoom", "", 0, "yyyyyyyyyyyyyyyyy", "zzzzzzzzzzzzzzzzzzzzzz", false, "myuser"]: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'record' at row 1

Seems that false is not correctly understood by the instert...

So ther room is not inserted in database..

@sualko
Copy link
Member

sualko commented Apr 27, 2020

@FlavioBill This has already be fixed, see #6

@sunjam This could definitely be enhanced.

@FlavioBill
Copy link

Thanks..
I have the version published in NextCloud App Store maybe this version is obsolete...
I try to take app direclty by git
:-)

@sualko sualko added enhancement New feature or request good first issue Good for newcomers labels Apr 28, 2020
@sualko sualko closed this as completed in 0074f71 Jun 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants