lsp_format_document breaks formatting when executed right after editing code

[MrFoxPro]

lsp_format_document.mp4

Seems like server is not fast enough to parse document after change and applies formatting to old version?

Environment:

• OS: Arch Linux 6.12.1
• Sublime Text version: 4180
• LSP version: 2.2.0, 2.3.0
• Language servers used: vstls, also tried LSP-typescript package

[jwortmann]

Seems like server is not fast enough to parse document after change and applies formatting to old version?

I'd say this looks more like textDocument/formatting is accidentally sent before textDocument/didChange (the didChange notification is debounced by 300 ms), so I think the server is doing the right thing. We should probably call purge_changes for the SessionBuffer before running the formatting request in

LSP/plugin/formatting.py

Line 116 in c64ac00

class LspFormatDocumentCommand(LspTextCommand):

and in

LSP/plugin/formatting.py

Line 177 in c64ac00

class LspFormatDocumentRangeCommand(LspTextCommand):

Next time ideally also post a copy of the logs directly, that would be easier than trying to read the logs from the video :)

[rchl]

Yes. I came to the same conclusion on discord where it was reported first

[du-song]

I ran into a bug(?): with lsp_ruff and lsp_pyright installed,

    "lsp_format_on_save": true,
    "lsp_code_actions_on_save": {
        "source.fixAll": true,
        "source.organizeImports": true,
    },

try saving this py file

import csv
import tempfile
import shutil
import os
C = 1
class CsvExporter:
    D = os.DirEntry
    X = tempfile

becomes

import tempfile
import os
import shutil
import tempfile

    D = os.DirEntry
    X = tempfile

I was suggested on Discord that this might the same bug, any plan on fixing this?