feat: add FailureBehavior enum to Cast immutable #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@gatesn - thanks for the PR. The change looks fine, but I think it needs to be rebased to get rid of the error we're seeing. Also, there's a linter for the commit message, so if you amend your commit message to match the title of your PR, it should be ok: |
gatesn
force-pushed
the
ngates/cast-failure-behavior
branch
from
736505c to
705fd66
Compare
gatesn
force-pushed
the
ngates/cast-failure-behavior
branch
from
705fd66 to
18a4879
Compare
|
I think that should be fixed up now |
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.