Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(pojos)!: avoid using raw proto enums in POJO layer #164

Merged
merged 1 commit into from
Aug 14, 2023
Merged

refactor(pojos)!: avoid using raw proto enums in POJO layer #164

merged 1 commit into from
Aug 14, 2023

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Aug 9, 2023 •
edited
Loading

BREAKING CHANGE: various public functions that took the
AggregateFunction.AggregationInvocation proto now take the POJO
equivalent Expression.AggregationInvocation.

@vbarua
Copy link
Member Author

vbarua commented Aug 9, 2023

AggregateFunction.AggregationInvocation was the only protobuf enum that didn't have a POJO equivalent.
I added one for consistency while I was looking into additional support for window functions.

@vbarua vbarua changed the title refactor!: avoid using raw proto enums in POJO layer refactor(pojos)!: avoid using raw proto enums in POJO layer Aug 9, 2023
@vbarua vbarua changed the title refactor(pojos)!: avoid using raw proto enums in POJO layer refactor(pojos): avoid using raw proto enums in POJO layer Aug 9, 2023
@vbarua
refactor(pojos): avoid using raw proto enums in POJO layer
833e666 
BREAKING CHANGE: various public functions that took the
AggregateFunction.AggregationInvocation proto now take the POJO
equivalent Expression.AggregationInvocation.
@vbarua vbarua force-pushed the vbarua/pojo-for-aggregation-phase branch from 41b3dad to 833e666 Compare August 9, 2023 20:47
@vbarua vbarua marked this pull request as ready for review August 9, 2023 20:56
@vbarua vbarua requested a review from jacques-n August 10, 2023 20:41
@vbarua vbarua mentioned this pull request Aug 11, 2023
Merged
@vbarua vbarua changed the title refactor(pojos): avoid using raw proto enums in POJO layer refactor(pojos)!: avoid using raw proto enums in POJO layer Aug 14, 2023
@vbarua vbarua merged commit 41c8400 into main Aug 14, 2023
@vbarua vbarua deleted the vbarua/pojo-for-aggregation-phase branch August 14, 2023 23:35
ajegou pushed a commit to ajegou/substrait-java that referenced this pull request Mar 29, 2024
@vbarua
refactor(pojos)!: avoid using raw proto enums in POJO layer (substrai…
cbac804 
…t-io#164)

BREAKING CHANGE: various public functions that took the
AggregateFunction.AggregationInvocation proto now take the POJO
equivalent Expression.AggregationInvocation.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbarua @EpsilonPrime