fix: account for struct fields in VirtualTableScan check #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Blizzara
force-pushed
the
avo/allow-structs-in-virtual-tables
branch
from
6089c13 to
0097759
Compare
Blizzara
changed the title
|
Pending confirmation from my employer on the CLA - will get back to this in a week hopefully! |
vbarua
reviewed
May 9, 2024
Blizzara
force-pushed
the
avo/allow-structs-in-virtual-tables
branch
from
0097759 to
d49a330
Compare
|
@vbarua @jacques-n I've signed the CLA and think this would be ready for review/to be merged! |
vbarua
reviewed
May 30, 2024
core/src/test/java/io/substrait/relation/VirtualTableScanTest.java
Outdated
Show resolved
Hide resolved
vbarua
requested changes
May 30, 2024
vbarua
approved these changes
May 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254 and adds a test