feat(spark): convert VirtualTableScan to LocalRelation #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blizzara
changed the title
Blizzara
force-pushed
the
avo/fix-spark-virtual-relations
branch
from
fe66521 to
65aa978
Compare
Blizzara
commented
Oct 24, 2024
| @@ -128,7 +128,7 @@ class ToSubstraitType { | |||
| ) | |||
| } | |||
|
|
|||
| def toAttribute(namedStruct: NamedStruct): Seq[AttributeReference] = { | |||
| def toAttributeSeq(namedStruct: NamedStruct): Seq[AttributeReference] = { | |||
There was a problem hiding this comment.
same rename as in #311
also fix LocalRelation -> VirtualTableScan for rows containing null values
Blizzara
force-pushed
the
avo/fix-spark-virtual-relations
branch
from
65aa978 to
f384d92
Compare
vbarua
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other direction (Spark -> Substrait) was already supported, but this adds Substrait -> Spark and enables round-trip testing.
Also fixes LocalRelation -> VirtualTableScan for rows containing null values.