feat: add upstream substrait version to package #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtia
approved these changes
Jun 15, 2023
jorisvandenbossche
approved these changes
Jun 15, 2023
|
|
||
| __substrait_version__ = "0.30.0" | ||
| __substrait_hash__ = "3259a1ba" | ||
| __minimum_substrait_version__ = "0.30.0" |
There was a problem hiding this comment.
What does the "minimum" version mean exactly? (is that a concept of substrait itself?)
There was a problem hiding this comment.
Looking forward, it's supposed to represent the oldest version of substrait that this library can parse a plan from. I don't think it will be used right away.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11