Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sendinblue/api-v3-sdk is abandoned - replace by getbrevo/brevo-php #384

Open
steeven-th opened this issue Jun 3, 2024 · 1 comment · May be fixed by #374
Open

sendinblue/api-v3-sdk is abandoned - replace by getbrevo/brevo-php #384

steeven-th opened this issue Jun 3, 2024 · 1 comment · May be fixed by #374

Comments

@steeven-th
Copy link

steeven-th commented Jun 3, 2024

Q A
Bug? yes
New Feature? no
Bundle Version 2.5
Sulu Version 2.5
Browser Version N/A

Actual Behavior

SuluFormBundle is waiting for the "sendinblue/api-v3-sdk" bundle

Expected Behavior

SuluFormBundle must wait for the new "getbrevo/brevo-php" bundle

Steps to Reproduce

Install the new BREVO bundle and test

Capture d’écran 2024-06-03 à 11 31 25

Possible Solutions

In DependencyInjection/SuluFormExtension.php file, line 199, replace this :

if ($config['sendinblue_api_key']) {
   if (!\class_exists(\SendinBlue\Client\Configuration::class)) {
      throw new \LogicException('You need to install the "sendinblue/api-v3-sdk" package to use the sendinblue type.');
   }

   $loader->load('type_sendinblue.xml');
 }

by this

if ($config['sendinblue_api_key']) {
   if (!\class_exists(\Brevo\Client\Configuration::class)) {
      throw new \LogicException('You need to install the "getbrevo/brevo-php" package to use the Brevo type.');
   }

   $loader->load('type_sendinblue.xml');
 }
@alexander-schranz
Copy link
Member

We need to find a way todo this without bc breaks. I will add a comment to #374

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants