Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Terminal - Get window size from vi #79

Closed
todo bot opened this issue Dec 12, 2018 · 0 comments
Closed

Terminal - Get window size from vi #79

todo bot opened this issue Dec 12, 2018 · 0 comments
Assignees
@roblabla
Labels
project-libuser Related to the libuser todo 🗒️ Created by the todo bot
Milestone
KFS-6

Comments

@todo
Copy link

todo bot commented Dec 12, 2018

Terminal defines a fullscreen size as 1280 * 800, but should really get it from vi instead.

https://github.com/roblabla42/KFS/blob/42d48b20bf345d877937578d7845304141937c9e/libuser/src/terminal.rs#L70-L80

This issue was generated by todo based on a TODO comment in 42d48b2 when #52 was merged. cc @roblabla.
@todo todo bot assigned roblabla Dec 12, 2018
@todo todo bot added the todo 🗒️ Created by the todo bot label Dec 12, 2018
@roblabla roblabla added project-vi Related to vi project-libuser Related to the libuser and removed project-vi Related to vi labels Dec 14, 2018
@roblabla roblabla added this to the KFS-6 milestone Jan 21, 2019
Orycterope referenced this issue in Orycterope/SunriseOS Mar 14, 2019
@Orycterope
vi: BACKBUFFER_ARR resolution
477982a 
The backbuffer is no longer hardcoded for 1280x800,
but instead holds enough memory for almost all screen sizes.

I could have dynamically allocated it, but I liked how
it resides in the .bss, and wanted to keep it that way.

Fixes #79

This revealed a problem with .bss and our userspace.ld, see sunriseos#216
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@roblabla roblabla

Labels
project-libuser Related to the libuser todo 🗒️ Created by the todo bot
Projects
None yet
Milestone
KFS-6
Development

No branches or pull requests
1 participant
@roblabla