Skip to content

Commit 686b7fa

Browse files
author
joel@joellee.org
committed
fix: strip out transformation changes
1 parent ef32ae7 commit 686b7fa

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

storage3/_async/file_api.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,19 @@ async def create_signed_url(
7474
] = f"{self._client.base_url}{cast(str, data['signedURL']).lstrip('/')}"
7575
return data
7676

77-
async def get_public_url(self, path: str, options: TransformOptions = None) -> str:
77+
async def get_public_url(self, path: str, options: TransformOptions = {}) -> str:
7878
"""
7979
Parameters
8080
----------
8181
path
8282
file path, including the path and file name. For example `folder/image.png`.
8383
"""
84-
render_path = (
85-
"render/image/authenticated" if options.get("transform") else "object"
86-
)
87-
transformation_query = urllib.parse.urlencode(options)
88-
query_string = f"?{transformation_query}" if transformation_query else ""
84+
render_path = "object"
85+
# render_path = (
86+
# "render/image/authenticated" if options.get("transform") else "object"
87+
# )
88+
# transformation_query = urllib.parse.urlencode(options)
89+
# query_string = f"?{transformation_query}" if transformation_query else ""
8990
_path = self._get_final_path(path)
9091
return f"{self._client.base_url}{render_path}/public/{_path}/{query_string}"
9192

storage3/_sync/file_api.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,19 @@ def create_signed_url(
7474
] = f"{self._client.base_url}{cast(str, data['signedURL']).lstrip('/')}"
7575
return data
7676

77-
def get_public_url(self, path: str, options: TransformOptions = None) -> str:
77+
def get_public_url(self, path: str, options: TransformOptions = {}) -> str:
7878
"""
7979
Parameters
8080
----------
8181
path
8282
file path, including the path and file name. For example `folder/image.png`.
8383
"""
84-
render_path = (
85-
"render/image/authenticated" if options.get("transform") else "object"
86-
)
87-
transformation_query = urllib.parse.urlencode(options)
88-
query_string = f"?{transformation_query}" if transformation_query else ""
84+
render_path = "object"
85+
# render_path = (
86+
# "render/image/authenticated" if options.get("transform") else "object"
87+
# )
88+
# transformation_query = urllib.parse.urlencode(options)
89+
# query_string = f"?{transformation_query}" if transformation_query else ""
8990
_path = self._get_final_path(path)
9091
return f"{self._client.base_url}{render_path}/public/{_path}/{query_string}"
9192

0 commit comments

Comments
 (0)