Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: operation on s3 protocol #592

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Nov 28, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

At times the storage.operation flag is not passed as a config when using the S3 protocol

What is the new behavior?

This PR fixes this inconsistency by using a function to compute the value when necessary

Copy link

Pull Request Test Coverage Report for Build 12065436208

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 77.859%

Totals Coverage Status
Change from base Build 11891699039: -0.002%
Covered Lines: 13932
Relevant Lines: 17752

💛 - Coveralls

@fenos fenos merged commit 5dbd9cd into master Nov 28, 2024
1 check passed
@fenos fenos deleted the fix/operation-flag-on-s3-protocol branch November 28, 2024 09:37
Copy link

🎉 This PR is included in version 1.13.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants