Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

support websockets #15

Closed
unixfox opened this issue Apr 26, 2019 · 6 comments
Closed

support websockets #15

unixfox opened this issue Apr 26, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@unixfox
Copy link

unixfox commented Apr 26, 2019

I would love to see a support for websockets.

@suyashkumar
Copy link
Owner

suyashkumar commented May 5, 2019

Great thought, I will need to look into WSS a bit more. Since WSS is just the websockets protocol over TLS (also on port 443 by default), I think the TLS handshake part should be the same. I'll need to look into the other differences specific to the websockets protocol.

Would you be interested in a potential contribution or discussion here?

@suyashkumar suyashkumar added the enhancement New feature or request label May 9, 2019
@fenio
Copy link

fenio commented May 16, 2019

I guess Home-Assistant doesn't work with this proxy because of lack of websockets support.
I wasn't able to get it working with it.

@lindell
Copy link

lindell commented Oct 26, 2019

This seems to have been fixed in the golang reverse proxy since Golang 1.12
I did just compile ssl-proxy with 1.13 and everything seems to work :)
golang/go#26937
https://go-review.googlesource.com/c/go/+/146437/

@unixfox
Copy link
Author

unixfox commented Oct 26, 2019

Should I close this issue then?

@lindell
Copy link

lindell commented Oct 26, 2019

I'm not sure which version the latest release is compiled with since I had to compile it myself (running on ARM)
https://github.com/suyashkumar/ssl-proxy/releases
There might be a need to recompile and release.

@suyashkumar
Copy link
Owner

@lindell thanks for the tip! I went ahead and re-released the prebuilt binaries built using Go 1.13.3 here: https://github.com/suyashkumar/ssl-proxy/releases so all should be good on the websockets front!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants