Skip to content

chore: do not run infinite-reactive-loop rule on Svelte 5 with runes #1006

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

baseballyama
Copy link
Member

Related #894.
But add a configuration to disable rules that are unnecessary when running with Svelte 5 Runes.

Copy link

changeset-bot bot commented Jan 12, 2025

🦋 Changeset detected

Latest commit: 819af26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

npm i https://pkg.pr.new/eslint-plugin-svelte@1006

commit: 819af26

@baseballyama baseballyama force-pushed the chore/infinite-reactive-loop branch from aa2bac7 to d570d15 Compare January 12, 2025 07:11
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 5fd91ba into main Jan 14, 2025
18 checks passed
@ota-meshi ota-meshi deleted the chore/infinite-reactive-loop branch January 14, 2025 05:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants