Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

5.19.1 breaks untrack #15077

Closed
gyzerok opened this issue Jan 21, 2025 · 9 comments · Fixed by #15079
Closed

5.19.1 breaks untrack #15077

gyzerok opened this issue Jan 21, 2025 · 9 comments · Fixed by #15079
Assignees

Comments

@gyzerok
Copy link

gyzerok commented Jan 21, 2025

Describe the bug

Our app becomes broken after update to 5.19.1 perhaps due to #15065

Image

Reproduction

UPDATE: REPL

Works fine for me if I switch to 5.19.0

Logs

System Info

Svelte 5.19.1

Severity

annoyance

@gyzerok
Copy link
Author

gyzerok commented Jan 21, 2025

Here is the repro

@elliott-with-the-longest-name-on-github
Copy link
Contributor

Hunch: it's this: #15065

@elliott-with-the-longest-name-on-github
Copy link
Contributor

Confirmed locally, reverting #15065 does indeed remove the error.

@trueadm
Copy link
Contributor

trueadm commented Jan 21, 2025

I'm looking into it.

@wiesson
Copy link

wiesson commented Jan 22, 2025

Has it been released? I'm also noticing errors and rolled our application back to 5.19.0

Foo.svelte:38 Uncaught (in promise) ReferenceError: $0 is not defined if I look up the file, there is no $0

    at untrack (chunk-BQV2ORY5.js?v=78936540:1667:12) <-- mentions untrack
    at chunk-6ALURLPR.js?v=78936540:2370:29
    at update_reaction (chunk-BQV2ORY5.js?v=78936540:1211:23)
    at update_effect (chunk-BQV2ORY5.js?v=78936540:1316:21)
    at flush_queued_effects (chunk-BQV2ORY5.js?v=78936540:1411:11)
    at flush_queued_root_effects (chunk-BQV2ORY5.js?v=78936540:1397:7)
    at flush_sync (chunk-BQV2ORY5.js?v=78936540:1522:5)
    at update2 (chunk-6ALURLPR.js?v=78936540:410:9)
    at chunk-6ALURLPR.js?v=78936540:423:11

@trueadm
Copy link
Contributor

trueadm commented Jan 22, 2025

Has it been released? I'm also noticing errors and rolled our application back to 5.19.0

Foo.svelte:38 Uncaught (in promise) ReferenceError: $0 is not defined if I look up the file, there is no $0

    at untrack (chunk-BQV2ORY5.js?v=78936540:1667:12) <-- mentions untrack
    at chunk-6ALURLPR.js?v=78936540:2370:29
    at update_reaction (chunk-BQV2ORY5.js?v=78936540:1211:23)
    at update_effect (chunk-BQV2ORY5.js?v=78936540:1316:21)
    at flush_queued_effects (chunk-BQV2ORY5.js?v=78936540:1411:11)
    at flush_queued_root_effects (chunk-BQV2ORY5.js?v=78936540:1397:7)
    at flush_sync (chunk-BQV2ORY5.js?v=78936540:1522:5)
    at update2 (chunk-6ALURLPR.js?v=78936540:410:9)
    at chunk-6ALURLPR.js?v=78936540:423:11

It has just now

@gyzerok
Copy link
Author

gyzerok commented Jan 22, 2025

Tried updating to 5.19.2 and reactivity seems to be broken somewhere around the REPL I've posted here. Will try to come up with modification to show reproduce tomorrow.

@trueadm
Copy link
Contributor

trueadm commented Jan 22, 2025

Tried updating to 5.19.2 and reactivity seems to be broken somewhere around the REPL I've posted here. Will try to come up with modification to show reproduce tomorrow.

Interesting, I look forward to seeing what it is, maybe we missed something else.

@wiesson
Copy link

wiesson commented Jan 25, 2025

Has it been released? I'm also noticing errors and rolled our application back to 5.19.0
Foo.svelte:38 Uncaught (in promise) ReferenceError: $0 is not defined if I look up the file, there is no $0

    at untrack (chunk-BQV2ORY5.js?v=78936540:1667:12) <-- mentions untrack
    at chunk-6ALURLPR.js?v=78936540:2370:29
    at update_reaction (chunk-BQV2ORY5.js?v=78936540:1211:23)
    at update_effect (chunk-BQV2ORY5.js?v=78936540:1316:21)
    at flush_queued_effects (chunk-BQV2ORY5.js?v=78936540:1411:11)
    at flush_queued_root_effects (chunk-BQV2ORY5.js?v=78936540:1397:7)
    at flush_sync (chunk-BQV2ORY5.js?v=78936540:1522:5)
    at update2 (chunk-6ALURLPR.js?v=78936540:410:9)
    at chunk-6ALURLPR.js?v=78936540:423:11

It has just now

I still get those errors, even though If I remove all usages of untrack in the whole code base. Any idea what it could be or how to narrow it down?

// edit: Ok, it comes from $state management or sth like this. Maybe related to bits-ui

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants