Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for new colour spaces #790

Closed
saivan opened this issue Jan 20, 2018 · 5 comments
Closed

Add support for new colour spaces #790

saivan opened this issue Jan 20, 2018 · 5 comments
Assignees
Milestone

Comments

@saivan
Copy link
Member

saivan commented Jan 20, 2018

http://stackoverflow.com/questions/2353211/hsl-to-rgb-color-conversion#9493060

Also add LAB and LCH spaces
as shown: https://en.wikipedia.org/wiki/HCL_color_space

@saivan saivan added this to the 3.0.0 milestone Feb 26, 2018
@saivan saivan self-assigned this Feb 27, 2018
@matuss1899
Copy link

I'll try this

@Fuzzyma
Copy link
Member

Fuzzyma commented Oct 19, 2018

Feel free to contact us on gitter if you need any help. Also make sure to work on the 3.0 branch. Good luck! :)

@matuss1899
Copy link

Hi, I created code to support required functionality outside of project, but I'm not really sure where to put them. I was thinking that maybe color.js or svg.js may be appropriate, but I'm not sure. Can you give me any directions regarding this?

@Fuzzyma
Copy link
Member

Fuzzyma commented Nov 4, 2018

Yes, it has to go into color.js. Please ignore all these comments sticking around there. They are basically for us, how we intend later api to work.

@matuss1899 matuss1899 mentioned this issue Nov 21, 2018
@saivan
Copy link
Member Author

saivan commented Dec 1, 2018

Okay, this is done now too, #939

@saivan saivan closed this as completed Dec 1, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants