Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Get rid of Bare in favour of Dom #935

Closed
Fuzzyma opened this issue Nov 21, 2018 · 2 comments
Closed

Get rid of Bare in favour of Dom #935

Fuzzyma opened this issue Nov 21, 2018 · 2 comments
Milestone

Comments

@Fuzzyma
Copy link
Member

Fuzzyma commented Nov 21, 2018

At the moment the adopter returns a Bare Object if the nodeName of the node cannot be converted to an svg object.
I would like to get rid of Bare altogether and just return a Dom Object instead.

With the dom object you have all dom capabilities you need. No other special stuff.
We dont know the nodeName anyway. So there is no use in assuming that it needs methods of Element or similar.

What do you think? @wout @saivan

PS: We ofc could add the words function to Dom which is really useful

@saivan
Copy link
Member

saivan commented Nov 24, 2018

Yes please 😁

@Fuzzyma
Copy link
Member Author

Fuzzyma commented Nov 24, 2018

Done in 858f19e. I also removed HTMLNode since it just was an empty class on top of dom. That makes the adopter even easier.
Good to see!

@Fuzzyma Fuzzyma added this to the 3.0.0 milestone Nov 24, 2018
@Fuzzyma Fuzzyma closed this as completed Nov 24, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants