Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vacancies in API v2 #1642

Closed
DeD1rk opened this issue May 2, 2021 · 6 comments · Fixed by #2024
Closed

Vacancies in API v2 #1642

DeD1rk opened this issue May 2, 2021 · 6 comments · Fixed by #2024
Assignees
Labels
api Issues related to the API app:partners Issues regarding the partners-app feature Issues regarding a complete new feature priority: medium A new feature or a bugfix that is non-critical.

Comments

@DeD1rk
Copy link
Member

DeD1rk commented May 2, 2021

Describe the solution you'd like

API v2 endpoints for partners and vacancies.

Motivation

It might be interesting to also show the partners and vacancies in the app some day. If we want to do that, we'll need them in the api. I suppose this might be something to discuss with the commissioner of external affairs.

Describe alternatives you've considered

Not doing it. If we don't want it in the app, we don't need it in the api.

@DeD1rk DeD1rk added priority: maybe someday This is not really relevant, but if we have nothing else to do, then we can think about this. board Need to involve the board feature Issues regarding a complete new feature app:partners Issues regarding the partners-app api Issues related to the API labels May 2, 2021
@se-bastiaan
Copy link
Contributor

Can you please use the issue template?

@se-bastiaan
Copy link
Contributor

@pingiun Do we maybe want to ask the board if this is a good idea?

@pingiun
Copy link
Contributor

pingiun commented May 3, 2021

I think it's a good idea to ask the commissioner of external affairs whether partners have ever asked for this. I don't think they have because the partners won't see the app at all (except when they become a members, which maybe has happened once). But maybe the commissioner can inquire whether partners would be interested in this. Either way, I will send an email to Michiel.

@DeD1rk
Copy link
Member Author

DeD1rk commented May 3, 2021

Yes I think it would in any case be very nice for partners, as it probably more than doubles their visibility. If desirable we could also add a field display_in_app or something, so it can be chosen per partner/vacancy.

@se-bastiaan
Copy link
Contributor

Given that we already exposed partners in API v1 they have also been exposed in v2. Nothing about vacancies tho.

@se-bastiaan se-bastiaan changed the title Partners and vacancies in API v2. Vacancies in API v2. Jul 28, 2021
@se-bastiaan se-bastiaan changed the title Vacancies in API v2. Vacancies in API v2 Jul 28, 2021
@pingiun
Copy link
Contributor

pingiun commented Sep 13, 2021

@wdoeland

@DeD1rk DeD1rk added priority: medium A new feature or a bugfix that is non-critical. and removed priority: maybe someday This is not really relevant, but if we have nothing else to do, then we can think about this. board Need to involve the board labels Oct 1, 2021
@DeD1rk DeD1rk self-assigned this Oct 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api Issues related to the API app:partners Issues regarding the partners-app feature Issues regarding a complete new feature priority: medium A new feature or a bugfix that is non-critical.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants