Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regression: Wrong request URL if server URL scheme is part of variable (works in v3) #5219

Open
StefanBauerTT opened this issue Aug 29, 2024 · 1 comment

Comments

@StefanBauerTT
Copy link

StefanBauerTT commented Aug 29, 2024

Q&A (please complete the following information)

  • OS: Windows
  • Browser: Firefox
  • Version: 129
  • Method of installation: Online Version https://editor.swagger.io/
  • Swagger-Editor version: online version
  • Swagger/OpenAPI version: OpenAPI 3.0

Content & configuration

Example Swagger/OpenAPI definition:

openapi: 3.0.2
info:
  title: Reproducer
  version: 1.0.0
servers:
  - url: '{url}'
    variables:
      url:
        default: https://dummy.restapiexample.com

paths:
  /api/v1/employees:
    get:
      responses:
        '200':
          description: Response

Describe the bug you're encountering

When executing the GET request, the Request URL is built incorectly.

To reproduce...

  • Click "GET /api/v1/employees"
  • Click "Try it out"
  • Click "Execute"

Expected behavior

Actual behaviour

Additional context or thoughts

This is a regression. It works when using docker run -d -p 80:8080 swaggerapi/swagger-editor:v3.18.1

It seems to be related to the URL scheme being part of the variable substitution, as the follwing example works fine:

openapi: 3.0.2
info:
  title: Reproducer
  version: 1.0.0
servers:
  - url: 'https://{host}'
    variables:
      host:
        default: dummy.restapiexample.com

paths:
  /api/v1/employees:
    get:
      responses:
        '200':
          description: Response
@StefanBauerTT StefanBauerTT changed the title Regression: Wrong Server URL if scheme is part of variable (works in v3) Regression: Wrong request URL if server URL scheme is part of variable (works in v3) Aug 29, 2024
@char0n
Copy link
Member

char0n commented Sep 20, 2024

Hi @StefanBauerTT,

This has been addressed upstream in https://github.com/swagger-api/swagger-js/releases/tag/v3.29.3. We would need to re-release the SwaggerEditor@4 to fix this issue in https://editor.swagger.io/.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants