fix(system): allow wrapping components both from presets and plugins #9919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7232 (comment)
Refs #7304
Motivation and Context
The expected behavior described in this issue has always been intended. It shouldn't matter if whether the plugins have been registered via
presets
or passed by theplugins
option. Having said that, this is just a bug in the original behavior, and the expected behavior (called chaining in this issue) should be the default one. Wrapping actions and selectors already works like that (ref #7304).In #7236, the remediation was provided, but unfortunately it also contains hidden bug, where the original components objects is being mutated by the combined plugins because of this line:
Action: we're gonna revert 516e666 and replace it with non-configurable solution. We're going to fix the mutation bug introduced by the line above.
How Has This Been Tested?
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests