Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(es): Select optimization level for each crates #10046

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 18, 2025

Description:

I used ddt cargo bin-size select-per-crate --compare --features plugin --release, the command added by swc-project/ddt#46

Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: f7fa09a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 18, 2025
@kdy1 kdy1 self-assigned this Feb 18, 2025
@kdy1 kdy1 added this to the Planned milestone Feb 18, 2025
@kdy1 kdy1 marked this pull request as draft February 18, 2025 07:34
@kdy1 kdy1 marked this pull request as ready for review February 18, 2025 08:10
@kdy1 kdy1 requested a review from a team as a code owner February 18, 2025 08:10
@kdy1
Copy link
Member Author

kdy1 commented Feb 18, 2025

With this PR:

❯ ll swc.darwin-arm64.node
-rwxr-xr-x  1 kdy1  staff    38M  2 18 17:17 swc.darwin-arm64.node

Main:

❯ ll swc.darwin-arm64.node
-rwxr-xr-x  1 kdy1  staff    41M  2 18 17:19 swc.darwin-arm64.node

@kdy1 kdy1 merged commit c28d494 into swc-project:main Feb 18, 2025
171 checks passed
@kdy1 kdy1 deleted the size branch February 18, 2025 08:35
@kdy1 kdy1 modified the milestones: Planned, v1.10.18 Feb 19, 2025
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #10046 will degrade performances by 4.08%

Comparing kdy1:size (f7fa09a) with main (6c7ec46)

Summary

❌ 2 regressions
✅ 194 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/jquery 128.1 ms 132.7 ms -3.47%
es/minifier/libs/moment 80.5 ms 84 ms -4.08%

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant