Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(es/minifier): Remove CompileUnit to simplify #10055

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 20, 2025

Description:

This type disturbs the transition to the core visitor.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Feb 20, 2025
@kdy1 kdy1 self-assigned this Feb 20, 2025
Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 51d8c60

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review February 20, 2025 01:54
@kdy1 kdy1 requested a review from a team as a code owner February 20, 2025 01:54
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 20, 2025
@kdy1 kdy1 enabled auto-merge (squash) February 20, 2025 01:55
@kdy1 kdy1 disabled auto-merge February 20, 2025 02:16
@kdy1 kdy1 merged commit c75578b into swc-project:main Feb 20, 2025
170 checks passed
@kdy1 kdy1 deleted the simplify-minifier branch February 20, 2025 02:16
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #10055 will improve performances by 5.54%

Comparing kdy1:simplify-minifier (51d8c60) with main (bc666be)

Summary

⚡ 1 improvements
✅ 195 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/moment 87.1 ms 82.5 ms +5.54%

@kdy1 kdy1 modified the milestones: Planned, v1.11.1 Feb 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant