Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug]: Destructuring null or undefined with rest #6390

Closed
p51lee opened this issue Nov 9, 2022 · 1 comment · Fixed by #6412
Closed

[Bug]: Destructuring null or undefined with rest #6390

p51lee opened this issue Nov 9, 2022 · 1 comment · Fixed by #6412
Labels
Milestone

Comments

@p51lee
Copy link

p51lee commented Nov 9, 2022

Describe the bug

The input code is destructuring null (or undefined) so it should throw TypeError exception but the transpiled code does not.

Input code

var { ... x } = null ; // or undefined

Config

No response

Playground link

https://play.swc.rs/?version=1.3.14&code=H4sIAAAAAAAAAytLLFKoVtDT01OoUKhVsFXIK83JUbAGAPSFhPAWAAAA&config=H4sIAAAAAAAAA0WMTQrEIAxG75K1286id5hDBCctFv9IUhgR714tlu7C915ehUMsrBUyshCPS0pU%2FMMKZAOKZZcVTNf6tKEXagYUeScdiiyd%2BZSEJjUQXHRbGSWbQmYSeRHG3T9m66GQfucYKmjJdAc%2F0N7G%2FHPynaLySe0Cj9ke9LUAAAA%3D

Expected behavior

The input code throws TypeError:

$ node input.js
input.js:1
var { ... x } = null ;
                ^

TypeError: Cannot destructure 'null' as it is null.
    at Object.<anonymous> (input.js:1:11)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Module._load (node:internal/modules/cjs/loader:878:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

Node.js v18.11.0

Actual behavior

The output code does not throw exception:

$ node output.js # no error

Version

1.3.14 (default SWC playground)

Additional context

No response

@swc-bot
Copy link
Collaborator

swc-bot commented Dec 15, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 15, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants