Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(bindings/types): Add missing mangle options #9298

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

chenjiahan
Copy link
Contributor

@chenjiahan chenjiahan commented Jul 20, 2024

Description:

Add missing mangle options to be consistent with the SWC documentation:

https://swc.rs/docs/configuration/minification#jscminifymangle

image

fix(types): add missing mangle options
@chenjiahan chenjiahan requested a review from a team as a code owner July 20, 2024 02:27
Copy link

changeset-bot bot commented Jul 20, 2024

⚠️ No Changeset found

Latest commit: 467686c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Jul 20, 2024

CodSpeed Performance Report

Merging #9298 will not alter performance

Comparing chenjiahan:mangle_options_0720 (467686c) with chenjiahan:mangle_options_0720 (ce2d571)

Summary

✅ 178 untouched benchmarks

@Austaras
Copy link
Member

You may refer to

pub struct JsMinifyOptions {

@chenjiahan
Copy link
Contributor Author

@Austaras I don't understand what you want me to change specifically. The purpose of this PR is to make TS type definitions consistent with Rust's implementation and SWC's documentation.

image

@Austaras
Copy link
Member

Sorry, I find the wrong config struct.

@chenjiahan
Copy link
Contributor Author

Haha, Terser's options are a bit confusing 😂

@kdy1 kdy1 added this to the Planned milestone Jul 20, 2024
@kdy1 kdy1 self-assigned this Jul 20, 2024
@kdy1 kdy1 changed the title fix(types): add missing mangle options fix(bindings/types): Add missing mangle options Jul 20, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 20, 2024 12:52
@kdy1 kdy1 merged commit 567f40d into swc-project:main Jul 20, 2024
154 checks passed
@chenjiahan chenjiahan deleted the mangle_options_0720 branch July 20, 2024 13:34
@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants