Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es/minifier): Fix detection of this #9339

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 29, 2024

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jul 29, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 29, 2024 02:52
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 29, 2024
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 8ea8e65

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 requested a review from a team as a code owner July 29, 2024 02:52
@kdy1 kdy1 enabled auto-merge (squash) July 29, 2024 02:53
@kdy1 kdy1 merged commit 77da7cf into swc-project:main Jul 29, 2024
154 checks passed
@kdy1 kdy1 deleted the issue-9148 branch July 29, 2024 03:23
Copy link

codspeed-hq bot commented Jul 29, 2024

CodSpeed Performance Report

Merging #9339 will degrade performances by 5.96%

Comparing kdy1:issue-9148 (9c1c646) with kdy1:issue-9148 (8998d29)

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark kdy1:issue-9148 kdy1:issue-9148 Change
es/full/bugs-1 532.6 µs 566.3 µs -5.96%

@kdy1 kdy1 modified the milestones: Planned, v1.7.4 Jul 31, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 31, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Minify strip method in object that should exist
1 participant