Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es/minifier): Preserve function length #9389

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 7, 2024

@kdy1 kdy1 added this to the Planned milestone Aug 7, 2024
@kdy1 kdy1 self-assigned this Aug 7, 2024
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: f72038a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review August 7, 2024 05:17
@kdy1 kdy1 requested review from a team as code owners August 7, 2024 05:17
@kdy1 kdy1 enabled auto-merge (squash) August 7, 2024 05:17
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 7, 2024
Copy link

codspeed-hq bot commented Aug 7, 2024

CodSpeed Performance Report

Merging #9389 will improve performances by 3.14%

Comparing kdy1:issue-9356 (f72038a) with main (f530476)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main kdy1:issue-9356 Change
es/full/bugs-1 566.7 µs 549.5 µs +3.14%

@kdy1 kdy1 merged commit 679682c into swc-project:main Aug 7, 2024
152 checks passed
@kdy1 kdy1 deleted the issue-9356 branch August 7, 2024 07:14
@kdy1 kdy1 modified the milestones: Planned, v1.7.8 Aug 7, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 7, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

minifier: incorrectly alters function length by removing the initializer values.
1 participant