Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es/typescript): Strip class modifiers #9399

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: af92a7d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Aug 8, 2024

CodSpeed Performance Report

Merging #9399 will degrade performances by 8.73%

Comparing magic-akari:fast-ts-strip (e39a292) with main (124e5ff)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 174 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:fast-ts-strip Change
es/full/bugs-1 541.6 µs 593.4 µs -8.73%
es/full/codegen/es2015 275.6 µs 290.6 µs -5.16%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.5 µs +3.52%
parse_and_babelify_jquery 113.8 ms 110.2 ms +3.28%

@magic-akari magic-akari changed the title fix(es/typescript): Handle more cases fix(es/typescript): Strip all class modifiers Aug 9, 2024
@magic-akari magic-akari changed the title fix(es/typescript): Strip all class modifiers fix(es/typescript): Strip class modifiers Aug 9, 2024
@magic-akari magic-akari marked this pull request as ready for review August 9, 2024 06:37
@magic-akari magic-akari requested a review from a team as a code owner August 9, 2024 06:37
@kdy1 kdy1 added this to the Planned milestone Aug 9, 2024
kdy1
kdy1 previously approved these changes Aug 9, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge once the publish pipeline ends

@kdy1
Copy link
Member

kdy1 commented Aug 9, 2024

I found that we can include this patch in 1.7.8. Can you fix the CI failures?

@magic-akari
Copy link
Member Author

I found that we can include this patch in 1.7.8. Can you fix the CI failures?

Which one?

@magic-akari
Copy link
Member Author

The ts-type strip still needs one or two additional fix.

@magic-akari
Copy link
Member Author

I found that we can include this patch in 1.7.8. Can you fix the CI failures?

patch-section.sh removed in c977c2b.
How to fix it?

@kdy1
Copy link
Member

kdy1 commented Aug 9, 2024

You can do cargo install cargo-link2 and do cargo link ../ from ./bindings. Sorry, I forgot documenting it.

@magic-akari
Copy link
Member Author

error: the #[global_allocator] in swc_malloc conflicts with global allocator in: swc_malloc

The CI process has failed due to a conflict with swc_malloc. Could you help me? @kdy1

@kdy1
Copy link
Member

kdy1 commented Aug 9, 2024

I'll take on this

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restored patch-sections.sh for now. Sorry for my mistake and I'll fix the bug of cargo-link after publishing this change.

@kdy1 kdy1 enabled auto-merge (squash) August 9, 2024 12:30
@kdy1 kdy1 modified the milestones: Planned, v1.7.8 Aug 9, 2024
@kdy1 kdy1 disabled auto-merge August 9, 2024 12:43
@kdy1 kdy1 merged commit 124e5ff into swc-project:main Aug 9, 2024
153 checks passed
himself65 added a commit to himself65/amaro that referenced this pull request Aug 9, 2024
himself65 added a commit to himself65/amaro that referenced this pull request Aug 9, 2024
marco-ippolito pushed a commit to nodejs/amaro that referenced this pull request Aug 10, 2024
@magic-akari magic-akari deleted the fast-ts-strip branch August 10, 2024 07:47
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 9, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants