Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es/typescript): Strip optional mark and definite mark #9411

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari requested a review from a team as a code owner August 9, 2024 15:57
Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: f6bce4d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Aug 9, 2024
@kdy1 kdy1 merged commit 8c161a0 into swc-project:main Aug 9, 2024
152 checks passed
Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #9411 will degrade performances by 5.19%

Comparing magic-akari:type-strip/optional-definite (f6bce4d) with main (124e5ff)

Summary

❌ 2 regressions
✅ 176 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:type-strip/optional-definite Change
es/full/bugs-1 541.6 µs 564.8 µs -4.11%
es/full/codegen/es2015 275.6 µs 290.7 µs -5.19%

@kdy1 kdy1 modified the milestones: Planned, v1.7.10 Aug 9, 2024
@magic-akari magic-akari deleted the type-strip/optional-definite branch August 10, 2024 07:47
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 9, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants