Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es/minifier): Force rename synthesized identifiers #9473

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 21, 2024

@kdy1 kdy1 added this to the Planned milestone Aug 21, 2024
@kdy1 kdy1 self-assigned this Aug 21, 2024
@kdy1 kdy1 requested a review from a team as a code owner August 21, 2024 03:52
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 21, 2024
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: e89129f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) August 21, 2024 03:52
@kdy1 kdy1 disabled auto-merge August 21, 2024 03:52
@kdy1 kdy1 requested a review from a team as a code owner August 21, 2024 03:53
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 21, 2024
@Austaras
Copy link
Member

Wait, so we could know what identifier is synthesized all this time along?

@Austaras
Copy link
Member

Tests failed. Otherwise PR looks good.

@kdy1
Copy link
Member Author

kdy1 commented Aug 21, 2024

Yeap. All Marks used for user-specified identifiers inherit from the top_level_mark.

@Austaras
Copy link
Member

Consider me shocked.

@kdy1 kdy1 enabled auto-merge (squash) August 21, 2024 04:35
@kdy1 kdy1 merged commit c72b5f8 into swc-project:main Aug 21, 2024
154 checks passed
@kdy1 kdy1 deleted the issue-9468 branch August 21, 2024 05:01
Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #9473 will not alter performance

Comparing kdy1:issue-9468 (e89129f) with main (3ee8980)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.7.17 Aug 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 23, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate variable declaration with compress and mangle
2 participants