Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es/module): Rewrite import specifier in type declaration #9577

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

CPunisher
Copy link
Member

@CPunisher CPunisher commented Sep 21, 2024

Description:

Use Arc<dyn ImportResolver> to reduce cost

Related issue:

@CPunisher CPunisher requested a review from a team as a code owner September 21, 2024 14:22
Copy link

changeset-bot bot commented Sep 21, 2024

🦋 Changeset detected

Latest commit: 2753310

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CPunisher CPunisher marked this pull request as draft September 21, 2024 14:26
@CPunisher CPunisher marked this pull request as ready for review September 21, 2024 14:39
Copy link

codspeed-hq bot commented Sep 21, 2024

CodSpeed Performance Report

Merging #9577 will improve performances by 3.24%

Comparing CPunisher:fix/rewrite-dts (2753310) with main (cf74382)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main CPunisher:fix/rewrite-dts Change
es/full/bugs-1 550.5 µs 533.3 µs +3.24%

@kdy1 kdy1 added this to the Planned milestone Sep 23, 2024
@kdy1 kdy1 changed the title fix(typescript): rewrite import specifier in type declaration fix(es/module): Rewrite import specifier in type declaration Sep 23, 2024
@kdy1 kdy1 self-assigned this Sep 23, 2024
@kdy1 kdy1 requested a review from a team as a code owner September 23, 2024 02:32
@kdy1 kdy1 merged commit fc0ba2a into swc-project:main Sep 23, 2024
18 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.28 Sep 24, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 24, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Paths are not transformed in dts files
2 participants