Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf(es): Avoid needless string comparisons #9613

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 4, 2024

Description:

@kdy1 kdy1 added this to the Planned milestone Oct 4, 2024
@kdy1 kdy1 self-assigned this Oct 4, 2024
Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: f4dfe2e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review October 4, 2024 05:31
@kdy1 kdy1 requested review from a team as code owners October 4, 2024 05:31
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 4, 2024
@kdy1 kdy1 enabled auto-merge (squash) October 4, 2024 05:36
@kdy1 kdy1 disabled auto-merge October 4, 2024 05:51
@kdy1 kdy1 merged commit ec0a62c into swc-project:main Oct 4, 2024
153 checks passed
@kdy1 kdy1 mentioned this pull request Oct 4, 2024
Copy link

codspeed-hq bot commented Oct 4, 2024

CodSpeed Performance Report

Merging #9613 will improve performances by 3.65%

Comparing kdy1:perf-parser-reserved (f4dfe2e) with main (e2e9a9c)

Summary

⚡ 2 improvements
✅ 192 untouched benchmarks

Benchmarks breakdown

Benchmark main kdy1:perf-parser-reserved Change
es/full/bugs-1 568.1 µs 548.1 µs +3.65%
es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.5 µs +3.44%

@kdy1 kdy1 modified the milestones: Planned, v1.7.31 Oct 8, 2024
@kdy1 kdy1 deleted the perf-parser-reserved branch October 14, 2024 01:11
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant