fix(es/transformation): Fix wrong syntax context of variables with the same names as catch params #9786
+31
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When hoisting variables, the names of catch params are saved in
catch_param_decls
permanently in the process. So the following code skips resolving the variables with the same names.swc/crates/swc_ecma_transforms_base/src/resolver/mod.rs
Line 1558 in e6fc532
I think this is introduced in #4574. I'm not sure why do that because I didn't find related test cases.
Related issue: