Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es): Restore JSON config & Adjust feature renaming #9967

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 27, 2025

Description:

I made a mistake while applying deprecations

@kdy1 kdy1 requested a review from a team as a code owner January 27, 2025 07:39
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 371c925

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 27, 2025
@kdy1 kdy1 self-assigned this Jan 27, 2025
@kdy1 kdy1 added this to the Planned milestone Jan 27, 2025
@kdy1 kdy1 enabled auto-merge (squash) January 27, 2025 07:39
@kdy1 kdy1 disabled auto-merge January 27, 2025 07:40
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 27, 2025
@kdy1 kdy1 changed the title fix(es): Restore JSON config fix(es): Restore JSON config & Adjust feature renaming Jan 27, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 27, 2025 08:06
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 27, 2025
@kdy1 kdy1 merged commit 72e5455 into swc-project:main Jan 27, 2025
167 checks passed
@kdy1 kdy1 deleted the fix-ci branch January 27, 2025 08:30
@kdy1 kdy1 modified the milestones: Planned, v1.10.11 Jan 27, 2025
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #9967 will degrade performances by 6.77%

Comparing kdy1:fix-ci (371c925) with main (1c2f7e9)

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 191 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 214.8 ms 208.4 ms +3.03%
es/full/minify/libraries/moment 125.4 ms 130 ms -3.51%
serialization of serde 2.8 µs 2.7 µs +4.38%
es/minifier/libs/jquery 170.2 ms 162.4 ms +4.82%
es/minifier/libs/moment 99.7 ms 107 ms -6.77%

@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 27, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant