Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

perf: Update rustc-hash to v2 and drop ahash #9982

Merged
merged 74 commits into from
Feb 1, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 1, 2025

Description:

@kdy1 kdy1 added this to the Planned milestone Feb 1, 2025
@kdy1 kdy1 self-assigned this Feb 1, 2025
@kdy1 kdy1 requested review from a team as code owners February 1, 2025 01:49
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 1, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 1, 2025
@kdy1 kdy1 enabled auto-merge (squash) February 1, 2025 01:52
Copy link

codspeed-hq bot commented Feb 1, 2025

CodSpeed Performance Report

Merging #9982 will degrade performances by 4%

Comparing kdy1:rustc-hash-2 (d1a906d) with main (99a6339)

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 191 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/bugs-1 468.1 µs 444.7 µs +5.25%
es/full/minify/libraries/jquery 204.4 ms 195.5 ms +4.57%
es/lints/libs/react 1.6 ms 1.7 ms -4%
es/minifier/libs/lodash 199.2 ms 206.1 ms -3.37%
es/minifier/libs/moment 103.6 ms 97.8 ms +5.9%

kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 1, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 1, 2025
@kdy1 kdy1 merged commit 6765db0 into swc-project:main Feb 1, 2025
171 checks passed
@kdy1 kdy1 deleted the rustc-hash-2 branch February 1, 2025 11:46
@kdy1 kdy1 modified the milestones: Planned, v1.10.13 Feb 3, 2025
@kdy1 kdy1 modified the milestones: v1.10.13, v1.10.14 Feb 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants