Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(es/transforms): Avoid adding __self in constructors of derived class in the jsx_self react transform #9987

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

@CPunisher CPunisher requested a review from a team as a code owner February 3, 2025 05:09
Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: 63edce6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #9987 will degrade performances by 4.15%

Comparing CPunisher:02-03-fix/jsx-self (63edce6) with main (61ae579)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/jquery 161.1 ms 156 ms +3.29%
es/minifier/libs/moment 97 ms 101.1 ms -4.15%
es/minifier/libs/vue 226.9 ms 234.7 ms -3.32%

@kdy1 kdy1 self-assigned this Feb 5, 2025
@kdy1 kdy1 added this to the Planned milestone Feb 5, 2025
kdy1
kdy1 previously approved these changes Feb 5, 2025
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you!

@kdy1 kdy1 requested a review from a team as a code owner February 5, 2025 00:21
@kdy1 kdy1 enabled auto-merge (squash) February 5, 2025 00:22
@kdy1 kdy1 disabled auto-merge February 5, 2025 03:01
@kdy1 kdy1 merged commit 83f24af into swc-project:main Feb 5, 2025
34 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.10.15 Feb 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
2 participants