Skip to content

[Traits] Integrate 'disallow disabling default traits of a package without traits' into resolution phase #8356

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
1 task done
bripeticca opened this issue Mar 11, 2025 · 0 comments · May be fixed by #8370
Open
1 task done
Assignees
Labels

Comments

@bripeticca
Copy link
Contributor

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

The PR #8326 has been successfully implemented in the modules graph loading phase, where traits were initially supported. Now that #8205 has been merged, this feature should be considered earlier on in resolution.

Expected behavior

The check for disallowing disabling default traits for a package without traits should be checked during resolution to omit any further calculations/checkouts/etc. if this condition fails.

Actual behavior

This check is being done after resolution has already completed.

Steps to reproduce

No response

Swift Package Manager version/commit hash

No response

Swift & OS version (output of swift --version ; uname -a)

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant