Skip to content

Commit a03037b

Browse files
committed
Catch known issues correctly
1 parent 1250b3c commit a03037b

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

Sources/Testing/ExitTests/ExitTest.swift

+8-2
Original file line numberDiff line numberDiff line change
@@ -504,8 +504,14 @@ extension ExitTest {
504504
let comments: [Comment] = event.messages.compactMap { message in
505505
message.symbol == .details ? Comment(rawValue: message.text) : nil
506506
}
507-
let issue = Issue(kind: .unconditional, comments: comments, sourceContext: .init(backtrace: nil, sourceLocation: issue.sourceLocation))
508-
issue.record()
507+
let sourceContext = SourceContext(
508+
backtrace: nil, // `issue._backtrace` will have the wrong address space.
509+
sourceLocation: issue.sourceLocation
510+
)
511+
// TODO: improve fidelity of issue kind reporting (especially those without associated values)
512+
var issueCopy = Issue(kind: .unconditional, comments: comments, sourceContext: sourceContext)
513+
issueCopy.isKnown = issue.isKnown
514+
issueCopy.record()
509515
}
510516
}
511517
}

0 commit comments

Comments
 (0)