Skip to content
This repository has been archived by the owner on Apr 5, 2020. It is now read-only.

Fails JSHint #18

Open
softwarespot opened this issue Jul 30, 2015 · 1 comment
Open

Fails JSHint #18

softwarespot opened this issue Jul 30, 2015 · 1 comment

Comments

@softwarespot
Copy link

Is this being maintained any more? If not I will gladly take over the project or at best become a contributor to the project.Just check out the projects I contributed to and you will see I have a fairly decent understanding of JS/jQuery. I feel this plugin has great potential =)

There are quire a few errors as well as a possible variable leak with the current code base, that I would fix, but considering PRs aren't being accepted/commented, I am a little reluctant to do so until I have an understanding that the project is still being maintained.

A couple of things I would change/add:

  • Add bower.json and submit to bower.io inc. semantic versioning [DONE (partially, not submitted)]
  • Fix the JSHint errors [DONE]
  • Refactor the code [DONE]
  • Improve efficiency (selectors aren't being cached or unnecessarily being recreated in a tight loop) [DONE]
  • Swap out deprecated jQuery functionality e.g. bind() => on() [DONE]
  • Add a grunt file for uglification and JS hinting [DONE]
@softwarespot
Copy link
Author

As an intermediate solution, I have forked the repository and will update the changes above there.

https://github.com/softwarespot/jquery-scrollspy

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant